search

Vinai / nicer-image-names

Magento extension to build catalog image file names from product attributes so they have neat descriptive names.
77 stars 31 forks source link

throwException Image file not found #6

Closed fplantinet closed 11 years ago

fplantinet commented 11 years ago

Are you Crazy to launch exception if image file not found ? !

I recommend at all to comment line 111 in Image.php ! Mage::throwException(Mage::helper('catalog')->__('Image file not found'));

Vinai commented 11 years ago

The behavior is simply compliant with the parent class Mage_Catalog_Model_Product_Image. See for yourself https://github.com/LokeyCoding/magento-mirror/blob/magento-1.8/app/code/core/Mage/Catalog/Model/Product/Image.php#L308

So, no, I'm not crazy, and I'm not going to change it. Stop using the extension if you don't like that.

fplantinet commented 11 years ago

it was a joke! sorry! but the result displays a lovely exception on a category page with products without image.

This module is great, and it is beautiful it is followed!

Vinai commented 11 years ago

The problem was that base/default placeholder images where not used. Fixed in commit ff16c72cf02584e3e4fa5f36636aafbca7c1241b