Throwing exception is not that good for development and live

Vinai / nicer-image-names

Magento extension to build catalog image file names from product attributes so they have neat descriptive names.

77 stars 31 forks source link

Throwing exception is not that good for development and live #7

Closed ScreamingDev closed 10 years ago

ScreamingDev commented 10 years ago

Especially for development. Live those messages might be suppressed.

#0 /var/www/codex/htdocs/app/code/community/Netzarbeiter/NicerImageNames/Model/Image.php(111): Mage::throwException('Image file not found')

(you were not in IRC so i mention it here)

Vinai commented 10 years ago

The exception is also thrown in the core code, so that will stay. The problem is that placeholder images from base/default where not used. This should be fixed in the commit ff16c72cf02584e3e4fa5f36636aafbca7c1241b.

ScreamingDev commented 10 years ago

That's it. Thanks!