search

VinceG / twitter-bootstrap-wizard

This twitter bootstrap plugin builds a wizard out of a formatter tabbable structure. It allows to build a wizard functionality using buttons to go through the different wizard steps and using events allows to hook into each step individually.
MIT License
1.39k stars 676 forks source link

onTabClick - Zero Based Indexes #128

Closed crona2011 closed 9 years ago

crona2011 commented 9 years ago

The onTabClick callback returns a zero based index of the tab you are currently on. Shouldn't this return the index of the tab that you clicked on, leaving the onTabShow and onTabChange to return a zero based index of the tab you are coming from/are currently on.

I have changed my version to reflect this.

crona2011 commented 9 years ago

Nevermind, I just found in your code d = g.index(e(d.currentTarget).parent('li:has([data-toggle="tab"])')); My apologies If i missed this in your documentation, if i did not it would be useful for others to know! :)