VinceG / twitter-bootstrap-wizard

This twitter bootstrap plugin builds a wizard out of a formatter tabbable structure. It allows to build a wizard functionality using buttons to go through the different wizard steps and using events allows to hook into each step individually.

MIT License

1.39k stars 676 forks source link

Made 'shown' event compatable with both Twitter Bootstrap 2.3.2 and 3.0.0 #46

Closed anorborg closed 11 years ago

anorborg commented 11 years ago

The purpose of this commit is to make the Bootstrap Wizard compatible with both the earlier version of Bootstrap and the latest version without having to make any additional modifications. This is done by attaching to both the legacy 'shown' event as well as the newer 'shown.bs.tab'. Since one or the other will be triggered, there should be no conflict by listening for both,

VinceG commented 11 years ago

@anorborg Thank You. I'll test this and merge.

anorborg commented 11 years ago

As stated, this is a sleeker implementation of the same fix.

anorborg commented 11 years ago

Sorry, I was attempting to do this as a separate pull request. for a separate issue (#33). Not sure the best way to back this out. I'm new to pull requests.

anorborg commented 11 years ago

I think I got everything worked out. Sorry. Github contributor newbie :-)

VinceG commented 11 years ago

@anorborg Thank You. Is #33 still relevant? if not can you close the pull request and close the ticket. Otherwise please state which pull request you want to review for merging.

Thank Again.

anorborg commented 11 years ago

33 is still relevant, just not for this request. I created a new branch and a separate pull request. Sorry for the confusion.

VinceG commented 11 years ago

@anorborg Please resubmit.

melisay commented 10 years ago

I am confused to find the BS3 support here. Can someone please help me?

VinceG commented 10 years ago

what are you confused about? @melisay