search

Vincent-P / gruvbox-intellij-theme

An IDE theme based on the gruvbox color scheme. ⛺
https://plugins.jetbrains.com/plugin/12310-gruvbox-theme
MIT License
126 stars 65 forks source link

Fix issue with cursor in pycharm console (#29) #33

Closed lemontheme closed 4 years ago

lemontheme commented 4 years ago

This PR provides a fix for the behavior described in #29.

In comparing the plugin's theme definitions with those of a handful of other plugins (e.g. Nord, Material, and Solarized), I noticed that ours don't specify a concrete value for CONSOLE_USER_INPUT, as shown here:

<option name="CONSOLE_USER_INPUT">
  <value />
</option>

When the value is specified, as below, the Pycharm's console cursor appears in the correct place. So it seems like Pycharm takes issue with the definition above. Shame it doesn't issue a warning or anything.

<option name="CONSOLE_USER_INPUT">
  <value>
    <option name="FOREGROUND" value="ebdbb2" />
  </value>
</option>

This isn't the only instance of <value /> in the theme definitions. I've also provided a concrete specification for CONSOLE_NORMAL_OUTPUT. The rest I've left as is, since there are no indications that they are causing problems.

Vincent-P commented 4 years ago

Thanks! I actually took a look at this this morning and found out these <value /> as well in the color scheme. I will review this and the other missing values tomorrow :)

Vincent-P commented 4 years ago

Sorry for the delay!

lemontheme commented 4 years ago

No worries! Thanks for merging. :)