search

VincentAmante / palia-tools

A fan-made garden planner for Palia
https://palia-garden-planner.vercel.app
Other
29 stars 5 forks source link

Add Corn and Spicy Pepper #19

Closed Mctalian closed 1 year ago

Mctalian commented 1 year ago

Probably more of a placeholder and showing my interest in contributing ❤️

I don't have the webp files and it's possible some of the data is slightly incorrect due to unknowns, but this should be a good start!

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
palia-garden-planner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 5:42am
VincentAmante commented 1 year ago

Heya! First of all thank you so much for making a pull request. I apologise that I haven't seen this till now, as I was also working on the same changes.

I unfortunately have to decline this one for a couple reasons, namely wanting to avoid incomplete additions merged to the main branch and also because I prefer to aggregate changes on either the hotfix or dev branch before merging it with Main. I ended up making commits with your crop-code suggestion and colour, but I'm also realising it's better if I had let you done that in another PR instead.

So sorry about this, you're actually the first pull-request I've had so I'm making rookie mistakes. I'm going to add more documentation and guidelines for making changes outside of what's currently in CONTRIBUTING.md. In hindsight, there probably should be a dedicated branch for new patches.

VincentAmante commented 1 year ago

Hello! Thinking back on it, as I believe I've fumbled this PR and made a couple changes based off it, it's only right I credit you for code contribution on the planner website. I prefer your suggestion of the cropcode, as well as the colours for the UI.

Your PR was a good attempt at adding the new crops, it also exposed potential flaws in how I've documented my project which I will be promptly reconsidering

Mctalian commented 1 year ago

Sounds good! I figured being incomplete it would get closed so no worries or hard feelings! I'm glad you were able to draw some inspiration from it!

I noticed a few things that can probably be smoother with some repeated code, so I may look into that and put a PR together. Again, no expectations on accepting it, but I'm hoping to make things easier for you going forward 🤞🏼