search

VincentH-Net / CSharpForMarkup

Concise, declarative C# UI markup for .NET browser / native UI frameworks
MIT License
748 stars 43 forks source link

Row()/Col() bug #7

Closed westito closed 4 years ago

westito commented 4 years ago

Remove "if (row != 0)" and simmilar "return if default value" conditions from Row/Col/ColSpan/RowCol/etc. functions. It took me days to realize my code not working because of this. I remove and re-add views from one grid to other and change order. Some of views not changed from row X to 0. This conditions are totally unnecessary!

VincentH-Net commented 4 years ago

Good catch! These checks are a minor performance improvement. I did not encounter your scenario before; will remove them.

VincentH-Net commented 4 years ago

This is fixed in the Xamarin Forms (4.6) implementation