VincentMasselis / TPMS-advanced

Android app for BLE TPMS made by Sysgration
Apache License 2.0
8 stars 3 forks source link

Can not add a two sensor package via QR code #14

Closed groissi closed 11 months ago

groissi commented 1 year ago

Due to the fact that a motorbike or a single axle trailer only has two wheels, I've ordered a package with two sensors for my motorbike. There was a one-click-binding QR code shipped with it, that only contains the address of two sensors instead of four.

Your QR code scanner logic only accepts a four code QR code text like '11AD8B&21563D&31A4F0&41A552' from your QR code sample. As mentioned my delivered code contains only two sensor addressed and looks like '1244BD&22191C'. I also attach the picture of the QR code card delivered at the bottom.

Could you please enhance the QR code scanner to also accept only two sensors, especially for the vehicle types 'motorbike' and 'single axle trailer'? Would be much appreciated.

qr_code_motorbike-tinified

VincentMasselis commented 1 year ago

Hello @groissi, thanks for submitting an issue and contributing for the app !

Until now, I've never seen a 2 wheel only packaging and the associated QR-code, thanks to the photo you filled, I can update the business logic which parse it.

An associated pull request will be opened soon to handle this. :)

groissi commented 1 year ago

Hej @VincentMasselis, awesome, thank you so much for your really quick reply, really appreciate it 👍