search

VincentToups / shadchen-el

shadchen is an emacs lisp pattern matching library
GNU Lesser General Public License v3.0
49 stars 7 forks source link

some small helps #6

Closed nicferrier closed 10 years ago

nicferrier commented 10 years ago

I removed a spurious cl-labels in my alist impl.

And I ert'd the tests although I don't understand what you're trying to do with the test-product stuff.

The other suggestion I'd like to make is that you pull all the shadchen stuff into the top-level and drop the use of eval-when because then emacs can find the source properly and all of that.

I also fixed a bug in lexical-match and I added stuff to make it possible to step into the match (and lexical-match) macro, at least for the value. We'd have to find a way to express the destructured match/expression to be able to step into those... might be tricky.

Oh. I also noticed that the version wasn't bumped in the file. I haven't updated that. Do you have a commit somewhere for that?

VincentToups commented 10 years ago

I've got a local commit for it, apparently. I'll rebase as push it.

Thanks for the contributions!

nicferrier commented 10 years ago

What do you think about the idea of moving all the code to top level? Shall I show you a PR for that?

VincentToups commented 10 years ago

Sure!