search

VincentVrijburg / moneybird-dotnet

A wrapper for the Moneybird API.
MIT License
6 stars 3 forks source link

Add SendInvoice method to ISalesInvoiceEndpoint #116

Closed mikevmil closed 1 month ago

mikevmil commented 2 months ago

Introduced SendInvoice method to ISalesInvoiceEndpoint and its implementation in SalesInvoiceEndpoint. Created SalesInvoiceSendOptions class to encapsulate sending options. Updated unit tests to include SendInvoice method verification. Added JSON response file for testing. All is written according to Moneybirds' documentation.

VincentVrijburg commented 1 month ago

Can you pull and merge latest develop into this? I had to change the codecov action version to fix the build pipeline preventing to merge.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.93%. Comparing base (dcab49e) to head (4518824). Report is 4 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #116 +/- ## ======================================== Coverage 98.93% 98.93% ======================================== Files 77 77 Lines 1129 1129 Branches 52 52 ======================================== Hits 1117 1117 Misses 5 5 Partials 7 7 ``` | [Flag](https://app.codecov.io/gh/VincentVrijburg/moneybird-dotnet/pull/116/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vincent+Vrijburg) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/VincentVrijburg/moneybird-dotnet/pull/116/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vincent+Vrijburg) | `98.93% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vincent+Vrijburg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikevmil commented 1 month ago

Can you pull and merge latest develop into this? I had to change the codecov action version to fix the build pipeline preventing to merge.

Done

mikevmil commented 1 month ago

@VincentVrijburg Would it be possible to release a new NuGet package with these new changes?

VincentVrijburg commented 1 month ago

I will create a package in a few minutes which will include your Uri fix as well. Thanks!