Buffer Overflow in unpack_jpg

[francobel]

The vulnerable unpack_jpg function in file jpg.c (https://github.com/VincentWei/MiniGUI/blob/master/src/image/jpg.c#L75) is used to decompress jpegs and create a raw bitmap version of the image.

In unpack_jpg, the values for cinfo.output_width and cinfo.output_height are retrieved directly from a jpeg file's header.

cinfo.output_width and cinfo.output_height can be manipulated by editing the header of the jpeg file being processed. They are two bytes each in the image's header so their values can range from 0x0000 to 0xFFFF. These variables are multiplied by 3.

When these three values are multiplied together they can exceed the limit of a 32-bit unsigned integer, leading to an integer overflow vulnerability. This product is used to set the size of the jinfo->jpg_surface, which will store the decompressed jpeg (https://github.com/VincentWei/MiniGUI/blob/master/src/image/jpg.c#L105). When the sizing arguments overflow, the array becomes too small to store the decompressed data.

The program writes the decompressed image to the array using the jpeg_read_scanlines function. The function ends up writing to out-of-bounds memory due to the buffer’s small size (https://github.com/VincentWei/MiniGUI/blob/master/src/image/jpg.c#L111). This causes data in memory adjacent to the buffer to be overwritten.

An attacker is in control of the image's height, width, and contents. This allows an attacker to craft an exploit to overwrite data in memory with data they control.

[VincentWei]

Many thanks for your detailed bug report! We will review this and fix it!