search

Vincentqyw / image-matching-webui

🤗 image matching toolbox webui
https://huggingface.co/spaces/Realcat/image-matching-webui
Apache License 2.0
761 stars 65 forks source link

Inconsistent Prints #56

Closed eyildiz-ugoe closed 2 months ago

eyildiz-ugoe commented 2 months ago

🐛 Bug Report

Even though I set the setting_geometry parameter in config to Fundamental, I still see Homography in some terminal prints.

[2024/08/20 12:55:55 hloc INFO] ransac_method: CV2_USAC_MAGSAC, geometry_type: Fundamental
[2024/08/20 12:55:55 hloc INFO] ransac_method: CV2_USAC_MAGSAC, geometry_type: Homography

🔬 How To Reproduce

Steps to reproduce the behavior:

  1. Set the parameter in config, and run python test_app_cli.py, which will run for all methods.

Environment

📎 Additional context

relevant part of the config that matters:

  setting_threshold: 0.1
  max_keypoints: 2000
  keypoint_threshold: 0.05
  enable_ransac: true
  ransac_method: CV2_USAC_MAGSAC
  ransac_reproj_threshold: 8
  ransac_confidence: 0.999
  ransac_max_iter: 10000
  ransac_num_samples: 4
  match_threshold: 0.2
  setting_geometry: Fundamental
Vincentqyw commented 2 months ago

Not a bug, as both H and F are estimated and stored in state caches. For further information, refer to #L582-L603. Within the UI configuration, Fundamental or Homography is solely utilized for image warping without the need for re-estimation.