search

Vincit / knex-db-manager

Utility for create, drop, truncate etc. administrative database operations.
https://vincit.github.io/knex-db-manager/
ISC License
142 stars 28 forks source link

Encode URI components #57

Closed gynnantonix closed 4 years ago

gynnantonix commented 5 years ago

https://github.com/Vincit/knex-db-manager/blob/99771ceeb29636621a600523810a7bb99f760fa6/lib/PostgresDatabaseManager.js#L260

DB passwords that contain non-URL-safe characters (e.g. hash marks) must be encoded so that pg can properly parse the connection string. Wrapping them in encodeURIComponent() should do the trick.

elhigu commented 5 years ago

Need to write test case and setup test databases to use hashes and colons in passwords.

elhigu commented 4 years ago

Fixed in next release.