Vincit / objection-graphql

GraphQL schema generator for objection.js
MIT License
307 stars 34 forks source link

A way of passing all models as array #49

Closed e200 closed 6 years ago

e200 commented 6 years ago

Is there a way we can pass an array containing all models instead of adding one by one using method chain????

koskimas commented 6 years ago

No

e200 commented 6 years ago

Any plans to add it?

timhuff commented 6 years ago

@koskimas I have a pull request open for this feature (submitted Feb 15th). Seems a reasonable API to have. Any reason why it hasn't been accepted? I also have two other pull requests open that I feel improve the usability of the library. I have the equivalent of this one for subscriptions on my fork but haven't bothered opening a pull request for it. Same story with this feature. I'd like to encourage the growth of this library, as I feel it's a great tool, it's been very beneficial to my work, and I see a lot of potential in it but it seems I might be wasting my time at this point.

edit: Upon re-reading, seems this could come off as whiney. I didn't write it with that tone. I was sincerely asking if there's a reason (e.g. not agreeing with the feature, implementation, etc) or if they've simply not been addressed due to a lack of manpower.

koskimas commented 6 years ago

@timhuff I haven't worked on this library in a while now. I can give you direct write access. I closed this issue as a reaction to the four question marks :smile: I'll add you as soon as github lets me (I wrote the wrong password too many times and cannot log in currently)

timhuff commented 6 years ago

@koskimas That'd be great! Thanks! Out of curiosity, what caused you to stop your work on it? Did you stop using objection and/or graphql? Or did you find that the approach wasn't flexible enough for your needs?

koskimas commented 6 years ago

@timhuff Do you have an npm account? I could add you there too so that you can make releases

timhuff commented 6 years ago

Yea, it's the same. timhuff.

timhuff commented 6 years ago

Thanks again. I'm really looking forward to working on it.

koskimas commented 6 years ago

@timhuff Done. To answer your earlier question, I just never ended up using graphql in any project. Also objection eats up most of my OSS time.