Get singular and plural model names from jsonSchema

Vincit / objection-graphql

GraphQL schema generator for objection.js

MIT License

307 stars 35 forks source link

Get singular and plural model names from jsonSchema #61

Open aurium opened 6 years ago

aurium commented 6 years ago

This is similar to listFieldName and fieldName from graphQLBuilder().model()'s extra parameter. It can simple replace listFieldName and fieldName if you can add collectiveName and singleName to your models's jsonSchema. The benefit is:

Center the model description;
Produce the correct single type name in the result graphQL schema;
Share the model identification with oder modules in the app.

andriibieriezhnoi commented 5 years ago

I ran into a problem when the name of the table is "users" and I have to write userss (double s)

i think this is a useful PR.

tsimons commented 5 years ago

Any thought on when this will be merged? I've run in to this issue now as well.

aizotov commented 5 years ago

Please merge 🙏

andriibieriezhnoi commented 5 years ago

@sbabushkin could you check this PR please? :)

CarlosFandango commented 4 years ago

Bump!

I've encountered this in my project as well. Would be great to get this merged in :)