search

Vindaar / TimepixAnalysis

Contains code related to calibration and analysis of Timepix based detector + CAST related code
MIT License
20 stars 6 forks source link

Center chip name written to `runs` instead of individual run #22

Closed Vindaar closed 5 years ago

Vindaar commented 5 years ago

Currently the centerChipName is written to the runs and reconstruction groups. While in practice this doesn't matter, this disallows having different detector data stored in a single HDF5 file!

Move this to each run individually.

Vindaar commented 5 years ago

There is a discrepancy between what PR #33 fixes and what this issue is actually about. What is not written in the OP of this issue is that the centerChipName is only written to the runs and reconstruction group, but not to the groups of the individual runs (which would be more precise). The latter is being added by #33.

However, the underlying issue of disallowing different detector data in a single HDF5 file is thus unsolved. The required changes (i.e. removing the attribute from the aforementioned groups) would be relatively small, but I believe it's not actually useful. For the time being anyways, the HDF5 files should remain valid only for a single detector. Thus I'll close this issue.