Vindaar / ggplotnim

A port of ggplot2 for Nim
https://vindaar.github.io/ggplotnim
MIT License
177 stars 15 forks source link

fix the examples which breaks Nim CI #104

Closed ringabout closed 3 years ago

ringabout commented 3 years ago

Ref https://github.com/nim-lang/Nim/pull/16418

See also https://github.com/brentp/nim-plotly/pull/68

ringabout commented 3 years ago

Where is the CI of ggplot?

If travis CI doesn't work, let's remove it and use github action. https://news.ycombinator.com/item?id=25338983

timotheecour commented 3 years ago

Where is the CI of ggplot?

well it's here https://github.com/Vindaar/ggplotnim/blob/master/.travis.yml but ya, IMO github actions or azure pipelines is the way to go

Vindaar commented 3 years ago

Wasn't aware of this: Travis is now completely useless for free projects (https://news.ycombinator.com/item?id=25338983) wtf.

Travis was never amazing and their forced switch from .org to .com was a fucking PITA already. Will switch in the coming days.

Thanks for the fix. Keep in mind this is due to a breaking change in chroma.