search

Vindaar / ggplotnim

A port of ggplot2 for Nim
https://vindaar.github.io/ggplotnim
MIT License
175 stars 15 forks source link

hide message "StatusSuccess output of write_to_png" #136

Closed pietroppeter closed 2 years ago

pietroppeter commented 2 years ago

This comes out every time we save a plot to png.

I tried to give a look from where this comes from. I cannot find in ggplotnim and I do not see it in ginger, where does it come from? cairo? is it possible to hide it?

Vindaar commented 2 years ago

Yeah, I should hide it. It was my reminder that I don't handle the return code from Cairo.

It comes from here: https://github.com/Vindaar/ginger/blob/master/src/ginger/backends.nim#L141

I need to replace that by a check if it was okay and maybe raise IOError if not okay. Thanks for the reminder!

pietroppeter commented 2 years ago

Ha, now I see why I was not finding it, I was looking for the full string or just for StatusSuccess 😂

pietroppeter commented 2 years ago

...and looking at that code I am reminded that ggplotnim can also output to svg!

I have planned a nbShow features for images and tables (see https://github.com/pietroppeter/nimib/issues/74) and maybe I could make use of that svg output (and incorporate in html).

Vindaar commented 2 years ago

I just pushed a new release of ginger (v0.3.11), which disables this status message. Instead it prints a warning message now, if the status is not StatusSuccess.

I'll close this issue now. If you (or someone) wants more control over the behavior of ginger when saving a plot, please open an issue over there: https://github.com/Vindaar/ginger/issues

I didn't want to turn the current behavior into an exception if the status is not success to avoid introducing new behavior.