search

Vindaar / ggplotnim

A port of ggplot2 for Nim
https://vindaar.github.io/ggplotnim
MIT License
175 stars 15 forks source link

make ggplot work with stricteffects #151

Closed ringabout closed 1 year ago

ringabout commented 1 year ago

ref https://github.com/nim-lang/Nim/pull/19380

Vindaar commented 1 year ago

Guess I broke the ggplotnim CI with a datamancer update. Ouch. Will fix it tomorrow.

Thanks for the PR though. Changing it to proc is fair enough. So the & thing will simply become a non side effect free function from now on?

ringabout commented 1 year ago

It is mostly a bug related to recursive call of procs https://github.com/nim-lang/RFCs/issues/435 this PR workaround the issue to make ggplotnim work with 2.0

Vindaar commented 1 year ago

New version is tagged. :+1:

ringabout commented 1 year ago

Thank you!