Allow DF `add` to work with initialized but empty first arg

Vindaar / ggplotnim

A port of ggplot2 for Nim

https://vindaar.github.io/ggplotnim

MIT License

176 stars 15 forks source link

Allow DF `add` to work with initialized but empty first arg #92

Closed Vindaar closed 3 years ago

Vindaar commented 3 years ago

Currently when using proc add(df: var DataFrame, toAdd: DataFrame) the requirement for exactly the same columns is only lifted for the case where the first argument is nil (DataFrame is a ref object).

However, to promote users to use newDataFrame instead of just declaring a DF, we should support said proc!

Vindaar commented 3 years ago

This has been implemented.