search

Vinelab / NeoEloquent

The Neo4j OGM for Laravel
MIT License
634 stars 200 forks source link

Not PHP7 compatible #142

Closed AzeemMichael closed 8 years ago

AzeemMichael commented 8 years ago

Get following error in PHP7

PHP Fatal error: Cannot use 'Null' as class name as it is reserved in /vendor/vinelab/neo4jphp/lib/Everyman/Neo4j/Cache/Null.php on line 9

heydavid713 commented 8 years ago

I fixed it in the underlying library that's causing the error. Will post a PR for it later today or tomorrow.

heydavid713 commented 8 years ago

I opened a PR with my changes to the neo4jphp library. @Mulkave if you want to, I can make the changes in the Vinelab version of neo4jphp.

Mulkave commented 8 years ago

@heydavid713 sure! PRs are always welcome 😄

Sorry for the late reply though.

heydavid713 commented 8 years ago

It's alright I know it was holiday season. I will fix the PR today as I thought Github used the commit hash for PRs and not the actual branch itself.