search

Vinelab / NeoEloquent

The Neo4j OGM for Laravel
MIT License
634 stars 200 forks source link

Replaced 'bindShared' with 'singleton' for laravel 5.2 #147

Closed nahiyan closed 8 years ago

nahiyan commented 8 years ago

'bindShared' has been replaced with 'singleton' as of laravel 5.2

heydavid713 commented 8 years ago

Please be aware that this breaks compatibility with Laravel 5.1

nahiyan commented 8 years ago

Yeah it does. I guess a specific version of NeoEloquent has to be released for 5.2.

bostinait commented 8 years ago

Will this pull request be accepted perhaps under a different version number to satisfy backwards compatibility?

nahiyan commented 8 years ago

Version 2.0 will be out within a week or two. Let's see what happens.

coreation commented 8 years ago

Are you sure this is working for L5.2? Because if I try to install your fork, I get the error that the pagination is still at 5.1?

Mulkave commented 8 years ago

@nahiyan thanks for the PR! Does that grant backward compatibility?

nahiyan commented 8 years ago

@Mulkave unfortunately, no :(

Mulkave commented 8 years ago

hmm in that case we can't merge into 1.2.11 and break backward compatibility with 5.0 and 5.1 :confused: I'll release a new version v1.3 to be considered the 5.2 compatible branch

Mulkave commented 8 years ago

@nahiyan please re-open your PR to 1.3.0, closing this one.