search

Vinelab / NeoEloquent

The Neo4j OGM for Laravel
MIT License
634 stars 200 forks source link

Laravel 5.3 compability? #168

Closed thanosalexander closed 4 years ago

thanosalexander commented 8 years ago

Is there any plan about integration laravel 5.3?

heydavid713 commented 8 years ago

Haven't tried it yet. Is it giving any particular errors?

thanosalexander commented 8 years ago

the first errors are in composer ..it needs to change from 5.2 to 5.3.

AzeemMichael commented 8 years ago

Your requirements could not be resolved to an installable set of packages.

Problem 1

thanosalexander commented 8 years ago

can you make a new branch with only theese changes?

        "illuminate/support": "5.2.*"     =>  "illuminate/support": "5.3.*",
        "illuminate/database": "5.2.*"    =>  "illuminate/database": "5.3.*" 
        "illuminate/pagination": "5.2.*"  =>  "illuminate/pagination": "5.3.*"
heydavid713 commented 8 years ago

Hey guys, I fixed some of the Issues with Laravel 5.3, while everything is not tested 100% I think I got basic functionality working. You can find it here. @Mulkave Should I do a PR for this? So I can get the Travis tests and possibly release it as 1.4 or any other number?

Mulkave commented 8 years ago

@heydavid713 sounds great! Thanks for the efforts. Is it a fork of the 1.4 branch?

heydavid713 commented 8 years ago

I saw that there was one, but I really didn't know if it would be compatible so I just based a new 1.4 from 1.3.2

Mulkave commented 8 years ago

@heydavid713 alright cool, I'd love to merge to a dev 1.4 branch if you create a PR.

heydavid713 commented 8 years ago

Ok. Will post the PR once I get to a PC

On Sep 8, 2016 6:11 AM, "Abed Halawi" notifications@github.com wrote:

@heydavid713 https://github.com/heydavid713 alright cool, I'd love to merge to a dev 1.4 branch if you create a PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Vinelab/NeoEloquent/issues/168#issuecomment-245553816, or mute the thread https://github.com/notifications/unsubscribe-auth/ALGPKX8w8z3dvRZA9XqI8F5ristgwhQdks5qn99QgaJpZM4JrqRR .

heydavid713 commented 8 years ago

@Mulkave Seems like I can't create a branch from a PR. Could you create the branch based on 1.3.2?

Mulkave commented 8 years ago

@heydavid713 done. There's a new 1.4 branch based off 1.3.2. Please PR to it. Much appreciated!

heydavid713 commented 8 years ago

I will recreate the branch as I did something very wrong with it. Will be up again by tonight.

On Mon, Sep 12, 2016 at 4:23 PM, Abed Halawi notifications@github.com wrote:

@heydavid713 https://github.com/heydavid713 done. There's a new 1.4 branch based off 1.3.2. Please PR to it. Much appreciated!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Vinelab/NeoEloquent/issues/168#issuecomment-246479230, or mute the thread https://github.com/notifications/unsubscribe-auth/ALGPKejxB5QPQ79hb5zh-UVJqRGajNDjks5qpbSngaJpZM4JrqRR .

thanosalexander commented 7 years ago

It seems its not pulling yet from 1.4.* branch.

heydavid713 commented 7 years ago

The PR is still open

On Sep 16, 2016 11:27 AM, "thanosalexander" notifications@github.com wrote:

It seems its not pulling yet from 1.4.* branch.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Vinelab/NeoEloquent/issues/168#issuecomment-247630455, or mute the thread https://github.com/notifications/unsubscribe-auth/ALGPKYIDnlQuDeM9ldxNZLxMPbtrn7l-ks5qqrVYgaJpZM4JrqRR .

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.