search

Vinelab / NeoEloquent

The Neo4j OGM for Laravel
MIT License
633 stars 199 forks source link

fix syntax error when building namespaced relation label #183

Closed apopiak closed 6 years ago

apopiak commented 7 years ago

see https://github.com/Vinelab/NeoEloquent/pull/109 for the original fix

apopiak commented 7 years ago

@Mulkave I'm not sure why the tests fail, care to enlighten me?

apopiak commented 7 years ago

Will there be a 1.3 release that includes this fix?

Mulkave commented 7 years ago

@apopiak sorry closed by mistake. The tests are failing due to an incompatibility with Illuminate's Connection class. Looking into it.

apopiak commented 7 years ago

Thanks, very much appreciated!

Mulkave commented 6 years ago

Just need a rebase so that we can merge this, better open to 1.4 instead.

apopiak commented 6 years ago

rebased onto 1.4 and there was no diff, someone must have fixed it already