Closed tomahock closed 6 years ago
Yes, this would be really appreciated especially for Vinelab/NeoEloquent 1.5-dev. I want to use this for a new Laravel project and would donate if it would ensure ongoing development of NeoEloquent including integration with graphaware/neo4j-php-client.
Does this works with Laravel 5.4?
Problem 1
@aamasri an integration of graphaware/neo4j-php-client was planned but due to being busy recently and not being able to allocate time for NE atm. Would love to review and merge contributions though, but this one isn't passing tests so I would refrain from merging to not break compatibility.
@Mulkave locally the tests pass.. Not sure why they are failing on travis.. I've been using this branch without errors, but I'm not using every feature on my project!
I think this need e little more work, but the basic is working!
@tomahock as long as the tests pass locally, means there's full backward compatibility. If you can confirm the tests then we're safe to merge
Well.. it's not 100% pass, but almost!
ERRORS!
Tests: 266, Assertions: 1087, Errors: 1, Warnings: 15, Incomplete: 7.
I'm going to try get some time to try to fix it!
@tomahock thanks for that, will be waiting for your fix, or if you can link to the branch where these tests exist maybe someone can lend a helping hand fixing that.
any update about this, i want to test it for my lumen based on laravel 5.4.*
Please fix this issue.
5.4 is supported: https://github.com/vinelab/neoeloquent#54
This would be a much appreciated upgrade