New client integration - Githubissues

transistive commented 2 years ago

I integrated the client into neo eloquent and greenbarred all tests.

Some pointers:

Some test results relating to id() usage are inconsistent. I have yet to figure out if this is a bug or if it is because of id's change around internally. If it is the latter we will have to rework the id() usage
I had to change some basic docker files
There are some inconsistencies in the type hinting which I haven't solved yet as they were already there in the library.

Hope this is up to standard :+1:

Looking forward to your feedback

transistive commented 2 years ago

Hi @KinaneD,

Thank you for the positive review!

The GitHub neo4j-php/neo4j-php-client is the source of the laudis/neo4j-php-client package, so it all works out. This discrepancy is there because I built the driver by myself in the beginning and then moved it to neo4j-PHP's GitHub. The next major version will probably move namespaces, but this is not set in stone yet.

I can help with future issues if needed!

Kind regards,

Ghlen

transistive commented 2 years ago

I took the liberty to change the Dockerfile and remove some unnecessary items in the composer file to make it all work for local development :+1:

Vinelab / NeoEloquent

New client integration #346