search

Vinelab / NeoEloquent

The Neo4j OGM for Laravel
MIT License
633 stars 197 forks source link

V1.8 #348

Closed transistive closed 2 years ago

transistive commented 2 years ago

Hi all,

I tried to integrate Neo Eloquent to work with newer versions of Laravel. I don't have a lot of time, so I started with the most relevant one: Laravel 8. It appears to work, minus the bugs still existing with ids.

Hope all is well,

Ghlen

kirkbushell commented 2 years ago

This appears to be busted, seeing the following error:

Declaration of Vinelab\NeoEloquent\ConnectionAdapter::selectOne($query, $bindings = []) must be compatible with Illuminate\Database\Connection::selectOne($query, $bindings = [], $useReadPdo = true)

This doesn't appear to have been tested very well, additionally the documentation for installation and configuration is now very outdated.

Finally, this is a very breakable change, and so probably should have been a 2.x release, imho.

kirkbushell commented 2 years ago

I stepped through this, and I'm not sure how this release is meant to work - there are so many issues with the API in Laravel 8.