search

Vinelab / cdn

CDN Assets Manager Package for Laravel.
MIT License
214 stars 71 forks source link

Moving config to .env #121

Open kshitijpurwar opened 7 years ago

kshitijpurwar commented 7 years ago

The CDN config such as region and bucketname should be moved to .env since it constitues sensitive info as well.

uselessscat commented 6 years ago

You only have to put in your config the env variable, like this example:

 'region' => env('AWS_S3_REGION', 'us-west'),
kshitijpurwar commented 6 years ago

@arie-cwhat What you say is absolutely correct but it's not included the code by default which I suppose it should be because a newbie like me could just put all the sensitive info there and get my self screwed later on. @Mulkave

uselessscat commented 6 years ago

I understand :+1: it's terrible to rewrite the whole history of git just to delete a line of code.