Vinelab / cdn

CDN Assets Manager Package for Laravel.
MIT License
216 stars 71 forks source link

Bug with s3 assets over https #35

Closed ebrigham1 closed 9 years ago

ebrigham1 commented 9 years ago

https://github.com/Vinelab/cdn/blob/master/src/Vinelab/Cdn/Providers/AwsS3Provider.php#L233

I think this would work more universally with host first and bucket after as aws s3 will get ssl certificate errors when attempting to serve over https for custom bucket domains, possibly only when they have dots (.) in them.

ex: https://s3.amazonaws.com/s3.hotrodhotline.com/ui/0/97/vZRlctTIE5.jpg

vs

https://s3.hotrodhotline.com.s3.amazonaws.com/ui/0/97/vZRlctTIE5.jpg