Diff Before Upload comparing filesize and last modified time.

Vinelab / cdn

CDN Assets Manager Package for Laravel.

MIT License

214 stars 71 forks source link

Diff Before Upload comparing filesize and last modified time. #90

Closed filipegar closed 8 years ago

filipegar commented 8 years ago

Well, I think I've achieved this in a very good way. To fix bug #26 and #84 I created a routine that gets a list of everything on bucket and conflicts with the collections of $assets received to upload. I check last modified time and file size. If both are different, the file passes this validation and gets uploaded.

filipegar commented 8 years ago

Travis failed on hhvm due to 'yield'. :\

publiux commented 8 years ago

I think this is a great PR. I created a fork of this project that I intend to maintain since this one seems slow to implement simple fixes. It is located at https://github.com/publiux/laravelcdn . I have integrated your pull request into the fork and have provided you with appropriate credit for the code. Thanks!

filipegar commented 8 years ago

Any news about this one? @Mulkave

Mulkave commented 8 years ago

Sorry for the delay on this one, will merge and allow failures on HHVM since it's not required as first-class support in this package.

filipegar commented 8 years ago

@Mulkave Great! Could you also push these changes to a new version on packagist? :) thanks.

Mulkave commented 8 years ago

@filipegar all up now, thanks a bunch :smile: