Vinetos / Tranquille

📲🚫 Block unwanted calls effortlessly. Supports regex. wildcard and open-source bans-lists. Fork of YetAnotherCallBlocker.
GNU Affero General Public License v3.0
24 stars 2 forks source link

Add support to Android 13 adaptive color launcher icon #15

Open alessandrojean opened 2 months ago

alessandrojean commented 2 months ago

Hi, came here after viewing your comment on the original app repository, I am looking forward into this fork as it seems very promising!

It would be nice if the app icon were updated to add support to Android 13+ dynamic color icon. It should be easy to do if the current icon is already adaptive, as it's just a matter of duplicating the <foreground> tag and renaming it to <monochrome>.

As it doesn't support currently, the app icon seems a bit off aside other apps' icons.

Reference: https://developer.android.com/develop/ui/views/launch/icon_design_adaptive

Android Studio also includes a themed icon previewer in recent versions: https://developer.android.com/studio/write/create-app-icons#preview-themed-app-icons

Thanks in advance!

alessandrojean commented 2 months ago

I took a further look, and it seems it was already partially added in ba1b18e, but I am not sure if the foreground with the "phone" part not being transparent will play well with the adaptive color toggled on (I think if it's on it will show just the "shield" part).

I can't test to see if it's the case at the moment, as I didn't manage to find the 0.0.1 APK in the releases page.

Vinetos commented 2 months ago

Hello ! Thanks for your investigation, I have not done any particular work to support this feature but I would happily integrate it ! :smile:

I have created a release for the 0.0.1 version if you want to give it a try : https://github.com/Vinetos/Tranquille/releases/tag/0.0.1

alessandrojean commented 2 months ago

Hi! I tested the release version and as I suspected the icon is only showing the shield when adaptive color is turned on, as you can see below.

So its just a matter changing the vector to exclude the phone part from the path and it should do the trick :)