search

VingtCinq / python-mailchimp

Python client for v3 of MailChimp API
MIT License
463 stars 131 forks source link

Remove logging of raw responses #212

Closed stephenross closed 5 years ago

stephenross commented 5 years ago

This update removes the response text from the logging action taken by the logger after a request is made to prevent runaway log file sizes. I have seen that recording the raw response text on certain large queries can cause log files to very quickly become massive and fill server drives, an obvious bad problem. We might want to add a note near the top of the README files that recommends that everyone update to 3.0.10+ due to this potential issue, but I will leave that as a suggestion instead of adding it to the README at the start of this update.

stephenross commented 5 years ago

@charlesthk Could you take a look at this and put it up on pypi when you get a chance?

charlesthk commented 5 years ago

Hi @stephenross I am on huge rush right now, I guess i will have enough time next week.

Thanks again for your massive contribution on this project.

stephenross commented 5 years ago

@charlesthk Hope you have finished the huge rush and have a moment to squeeze tossing this up on PyPi this week. Let me know if there is anything I can do to help.

charlesthk commented 5 years ago

Hi @stephenross I have looked to your PR and I agree with it. I will publish the new version on PyPI. However, for debbuging purpose, I think it would be great to have a settings (disabled by default) that add response.text to the log.