Vinifera-Developers / Vinifera

Vinifera is a C&C: Tiberian Sun engine extension implementing new logics and fixing bugs.
GNU General Public License v3.0
45 stars 10 forks source link

[New Feature] Placing factory rally points without holding Alt #42

Open Rampastring opened 3 years ago

Rampastring commented 3 years ago

Description:

Tiberian Sun allows you to place rally points for factories. However, the vanilla game requires you to hold Alt while placing rally points, because of which most players were never aware of this functionality until CnCNet TS came along and changed the game to allow setting rally points like RA2, without needing you to hold any special keys.

What makes this a bit trickier for TS is Mobile War Factories: being able to place rally points without holding Alt prevents the player from undeploying deployed Mobile War Factories. Unless a patch is made to allow undeploying them by holding Alt instead.

Possible Implementation:

CnCNet TS-patches implementation: https://github.com/CnCNet/ts-patches/blob/master/src/factory_rallypoints.asm Alt to undeploy: https://github.com/CnCNet/ts-patches/blob/master/src/alt_to_undeploy.asm

CCHyper commented 3 years ago

I believe this should be a new default QoL change, but The Mobile War Factory does present a problem here...

A couple of solutions;

  1. Disable this on Mobile War Factories, keeping the original behaviour.
  2. Change Mobile War Factories so they must be manually undeployed.
Rampastring commented 3 years ago

I think option 1 would be more user-friendly for new players. Experienced players might want this to be configurable through SUN.ini though.

CCHyper commented 3 years ago

On second thought, I have a concern that having two ways of setting the rally point might be confusing for some players.

Can anyone think of another way we could resolve this?

Rampastring commented 3 years ago

Placing rally points without holding Alt is the standard in all newer RTS games I think, so I'd prioritize it.

If we want to standardize the behaviour, I'd rather make undeploying units require Alt as it's easy to accidentally un-deploy some of your deployed units when you're ordering units around. This would require a fitting tip text to be shown in the UI though (maybe a text like "Alt " next to the move cursor when you have deployed units selected).