search

Vinifera-Developers / Vinifera

Vinifera is a C&C: Tiberian Sun engine extension implementing new logics and fixing bugs.
GNU General Public License v3.0
44 stars 10 forks source link

[New Feature] Hardcoded name and type checks. #554

Open tomsons26 opened 3 years ago

tomsons26 commented 3 years ago

Description:

TS has quite a few hardcoded name checks. Making this issue to keep track of them.

00681259 check for "155mm" which then hardcodes its ROF and Attack. 0066F4D3 "ARTYHE", hardcoding its verses. 00587DF1 006527B7, "APC" check, this is for switching to water image. #553 0040932F Aircraft damage smoke 00440C38 NAFNCE NAPOST harcoded to set IsBase to false 004834DF Droppods hardcoded to spawn SMOK 00588C5F HMEC hardcoded strength 0063BB3D GAFSDF GAWALL NAWALL hardcoding ThreatRange 0063BB82 E2 forced to Explode.

Possible Implementation:

I guess if these set their hardcoded properties should be controlled from rules to remain compatible with stock TS.

TODO check for more, check if TS rules match what the hardcoded values are, in such case we can just remove some of the code.

CCHyper commented 3 years ago

@tomsons26 (and anyone else), what do you feel would be the best approach for disabling/enabling these items?

Crimsonum commented 3 years ago

@tomsons26 (and anyone else), what do you feel would be the best approach for disabling/enabling these items?

Just an idea, maybe a global [General] key OverrideHardcodedRules (bool) ? Defaults to 'no'. If set, effectively disables all of the listed hardcoded name checks/features.

CCHyper commented 1 year ago

To retain a history of the values;