search

VinodAnandan / sonar-pitest

43 stars 30 forks source link

allow kotlin files #17

Closed sarahBuisson closed 6 years ago

sarahBuisson commented 6 years ago

@bradflood The pull request pass, the issue in the build is that the sonar cannot be reach. Can anyone do something?

bradflood commented 6 years ago

@VinodAnandan I'm looking into some configuration changes for Travis. It appears the SonarCloud Travis addon does not properly invoke the sonar scanner for a pull request not originating within the organization [1] although there are plans to include support for external pull requests [2].

if we want to accept external PRs (recommended), then we'll have to remove the SonarCloud Travis addon and use something similar to what SonarSource does [3]. I've started down that path, but wanted to check with you first before completing. SonarSource has a good example to follow. Should have it ready tomorrow

[1] https://docs.travis-ci.com/user/sonarcloud/#Activation-for-internal-pull-requests For security reasons, this advanced feature works only for INTERNAL pull requests. In other words, pull requests built from forks won’t be inspected. [2] https://docs.travis-ci.com/user/sonarcloud/#Upcoming-improvements [3] https://github.com/SonarSource/sonarqube/blob/master/travis.sh [4] https://docs.sonarqube.org/display/PLUG/GitHub+Plugin

VinodAnandan commented 6 years ago

@sarahBuisson Thank you very much for your valuable contribution to sonar-pitest plugin. This feature will be added to the upcoming release.

@bradflood Thanks a lot for spending time with the Travis integration problems, please go ahead with the improvements.