Vinodjayakumar124 / pe

0 stars 0 forks source link

Unclear numbering for new clients added #6

Open Vinodjayakumar124 opened 1 year ago

Vinodjayakumar124 commented 1 year ago

The number of the client doesn't match the expected numbering. When a client is deleted, the numbering should either be standardised to filling in the missing Ids, or it should begin from a previously unused id. However, it follows the following pattern.

Before delete command for id 7: client -d 7 image.png

After delete command for id 7: client -d 7 image.png

After delete command for id 5: client -d image.png

Adding a new client client -a n/Jhonny p/7 image.png

Numbering goes back to 7. The number should have started from 8. Otherwise, if it was filling up the gaps, it should have filled up id 5.

nus-pe-script commented 1 year ago

Team's Response

Thanks for the suggestion! We acknowledge that having a continuous ID sequence can be an alternative way to handle the IDs of the different entities. However, we have decided on this method of implementation because having constantly changing IDs for each entity would make it confusing for the user to input commands - they would have to check the current ID of the entity before executing the command with the correct input.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]