search

Vinubaba / SANTC-API

1 stars 1 forks source link

UI Issues Running List #3

Closed Vinubaba closed 6 years ago

Vinubaba commented 6 years ago

https://docs.google.com/spreadsheets/d/15nkI3ofkSvwy7tuztk70TY2XmUiUzUvG5_T7curjMCM/edit#gid=0

JohnGallego commented 6 years ago

I was talking about just the email icon and the login change, not about the kids view yet., although that's next so it helps!

Vinubaba commented 6 years ago

the login should be actually log out, you cant be logged out and see all of these screens. so change the login to log out. the login is a seperate page. when the search box is clicked, the underline border should change to the dark purple , like the 1 px purple line you use under the main navigation. also the search icon should change from grey to the purple outline.

i haveno idea what you said here :-) just need to add a small state change to support the login and email change. Not sure how you want to trigger it. I guess I can cycle it every few seconds maybe?

Vinubaba commented 6 years ago

no idea what you mean here

Should the Student's name be in the button, or just the icon?

what button? what icon? :-)

Vinubaba commented 6 years ago

what do you think of a divider line between the card for the name and action menu . is that easily done for you or will ir several hours?? image

JohnGallego commented 6 years ago

The line should be easy. I'll make the changes to search bar some time today.

Vinubaba commented 6 years ago

ok can you clarify my questions above please when you have a chance

JohnGallego commented 6 years ago

With state change I mean the app will eventually have a state of: no new messages, and one of: new messages. that state will be displayed in the header with the different icon. Of course this will be driven by the back end - the state will reflect whether the back end shows new messages or not. We don't have that now, so how would you like me to trigger the two different states so that you can see both states represented in the header?

I can add a button at the bottom, for example that you can click to toggle "new messages" state vs "no messages state". Or I can just leave the app in an "new messages" state since you already know what the other state looks like.

Vinubaba commented 6 years ago

This is fine just leave the app in an "new messages" state since you already know what the other state looks like. _

I can just leave the app in an "new messages" state since you already know what the other state looks like.

_

Vinubaba commented 6 years ago

please can you tighten this image

JohnGallego commented 6 years ago

Will do.

Vinubaba commented 6 years ago

some of my tightening px might be off, i am just eye balling it.

JohnGallego commented 6 years ago

Vinu can you clarify the following for me:

banner changes_annotated

  1. Do you mean decrease the space between View and Add by 20px? That will look uneven with the rest of the menu items, or do you move the entire menu item list 20 pixels to the right? I don't think I can do that without reducing the font size of the menu items.

2 Same question, am I decreasing the space between items (which I can't do without changing font size) or move the entire list over to the right by 30 pixels? I can move the entire list over in this case.

Vinubaba commented 6 years ago

Like the arrows point to, i am pointing to the white space (height, vertical height). I am eye balling it so if the pixels are too much to decrease by, make it half, example 20 becomes 10 and 30 becomes 15.

JohnGallego commented 6 years ago

Latest build is ready: https://teddy-care-project.firebaseapp.com/view-kids

Let me know.

Vinubaba commented 6 years ago

here is my feedback. there are more on the cards . that i have not included but trying to focus on the header for now . image let me know if you have questions or do you need to talk??

Vinubaba commented 6 years ago

we are getting there, thank you, there is progress.

Vinubaba commented 6 years ago

The phone version - the search term is being underlined when i type in the box for some reason.

JohnGallego commented 6 years ago

I'll look into it, can you tell me what phone/browser?

Vinubaba commented 6 years ago

I am using a samsung s7 with chrome (android)

Regards,

Vinu Singh 972-523-0729

On Thu, Feb 8, 2018 at 3:47 PM, John Gallego notifications@github.com wrote:

I'll look into it, can you tell me what phone/browser?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DigitalFrameworksLLC/teddycare/issues/3#issuecomment-364259192, or mute the thread https://github.com/notifications/unsubscribe-auth/Aia-_6ROPBqpPe5bXcN9pYMPSl64q23Mks5tS2ttgaJpZM4R6Dmf .

JohnGallego commented 6 years ago

Latest build is ready: https://teddy-care-project.firebaseapp.com/view-kids

The underlining on mobile is your spellchecker. You'll notice that if you hit space or click on an auto complete option on your mobile keyboard the underlining goes away. I added some flags that will turn it off in some browsers, but not all browsers will honor the flags.

Vinubaba commented 6 years ago

Thanks John! Can we talk tomorrow on the next screen (view cards and a few formatting things in the cards that we have kind of talked about). then we will be done with view initial screen also in addition to the header. and I can talk about next things and plans. Can I call you around 9 AM = 10 EST?

JohnGallego commented 6 years ago

Yep ill be here

JohnGallego commented 6 years ago

ok latest build is up with the latest changes to the header. font awesome doesn't have a filled in version of the search icon, so i left it the same color as the search text, but turned it blue when the input box receives focus.

let me know if this closes the header or if there are further changes. I'll close both the header and this issue so we can continue on a new one.

also please dont forget to setup the new project with upwork, or if you want I can create a statement of work and bill you separately if you want. just make sure you include all project scope for whatever you need now so i can itemize. thanks!

Vinubaba commented 6 years ago

maybe we should do a seperate SOW so you can save the money for comissions ? upto you.

Vinubaba commented 6 years ago

i think the log out needs to be a link too so that user can click on it to log out.. right now you just have it as text. also when i click on the search icon, it is reverting back to its initial state color and the text box also loses focus - which it shouldnt right?. is it a bug.

JohnGallego commented 6 years ago

I'll make those changes in a jiffy.

JohnGallego commented 6 years ago

OK, changes made, let me know.

In terms of the contract, just email me the full scope and I'll send you the itemized statement of work.

Vinubaba commented 6 years ago

sorry but the logout is now being underlined which is not the look nd feel, it just needs to show the mouseover like other links. also the search icon should be clickable because the user might want to click it after typing the search name.

JohnGallego commented 6 years ago

All set.

Vinubaba commented 6 years ago

now the log out has become huge! should be 14 px

image

JohnGallego commented 6 years ago

I changed it to a nav button like the other ones but I can lower the font size, give me a sec.

JohnGallego commented 6 years ago

ok give it a shot

Vinubaba commented 6 years ago

done good thanks. yeah the mocup is my refrence.

JohnGallego commented 6 years ago

Cool I'll close this then?

Vinubaba commented 6 years ago

Yes thanks

On Fri, Feb 9, 2018, 3:19 PM John Gallego notifications@github.com wrote:

Cool I'll close this then?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DigitalFrameworksLLC/teddycare/issues/3#issuecomment-364570586, or mute the thread https://github.com/notifications/unsubscribe-auth/Aia-_0LDzEEDJC1cWA1z6GVzrvYeFUVUks5tTLZagaJpZM4R6Dmf .