VinylRecords / Vinyl

Extensible Records for Haskell. Pull requests welcome! Come visit us on #vinyl on freenode.
http://hackage.haskell.org/package/vinyl
MIT License
261 stars 49 forks source link

Stackage LTS-15 release #138

Open baskaransri opened 4 years ago

baskaransri commented 4 years ago

Hi, I was wondering how I could help get a Stack LTS-15 release of Vinyl out?

acowley commented 4 years ago

Test that it builds, and we'll open the PR! I think it should build, but I haven't had the chance to try.

baskaransri commented 4 years ago

Everything seems to work.

Changing stack.yaml to just the line:

resolver: lts-15.14

and running stack test says all 36 tests pass and I get

/home/baskaran/Haskell/misc-libraries/Vinyl/tests/CoRecSpec.hs:50:50: warning: [-Wdeferred-type-errors]
    • Couldn't match type ‘'[Int]’ with ‘'[]’
      Expected type: Either [Char] (CoRec Identity '[])
        Actual type: Either
                       [Char]
                       (CoRec
                          Identity
                          (Data.Vinyl.TypeLevel.RDelete
                             Bool (Data.Vinyl.TypeLevel.RDelete () '[Int, Bool, ()])))
    • In the third argument of ‘either’, namely ‘(handlers x)’
      In the first argument of ‘shouldNotTypecheck’, namely
        ‘(either id matchNil (handlers x))’
      In the expression:
        shouldNotTypecheck (either id matchNil (handlers x))
   |                 
50 |       in shouldNotTypecheck (either id matchNil (handlers x))
   |                                                  ^^^^^^^^^^

Which I assume is expected. Hurrah!

locallycompact commented 4 years ago

Hi this doesn't seem to have made it back into stackage. I've checked and it does work against 2020-07-29.

acowley commented 4 years ago

Any idea why our last attempt to get it added didn’t stick?

Lysxia commented 4 years ago

There's another occurence of vinyl in Stackage's list, which seems to be disabling it: https://github.com/commercialhaskell/stackage/blob/b6de4b94321faaee4ed99639e35b95f97fd9f324/build-constraints.yaml#L2685

acowley commented 4 years ago

Thank you, @Lysxia! I've opened a new PR.