Build without warnings (-Wall -Wcompat)

VinylRecords / Vinyl

Extensible Records for Haskell. Pull requests welcome! Come visit us on #vinyl on freenode.

http://hackage.haskell.org/package/vinyl

MIT License

260 stars 49 forks source link

Build without warnings (-Wall -Wcompat) #155

Open int-index opened 2 years ago

int-index commented 2 years ago

The following warnings should no longer get triggered:

-Wnoncanonical-monoid-instances
-Wnoncanonical-monad-instances
-Wstar-is-type

int-index commented 2 years ago

The CI failure is not related to this patch. The problem is that test-suite aeson is not compatible with newer aeson (could be fixed either by updating the code or adding an upper bound).

I can rebase when this is addressed.

acowley commented 2 years ago

This kind of maintenance is greatly appreciated, thank you! I’ll look into the test suite issue.