Support GHC 8.4 - Githubissues

VinylRecords / Vinyl

Extensible Records for Haskell. Pull requests welcome! Come visit us on #vinyl on freenode.

http://hackage.haskell.org/package/vinyl

MIT License

261 stars 49 forks source link

Support GHC 8.4 #168

Closed raehik closed 1 year ago

raehik commented 1 year ago

GHC 8.4.4 is stated in the tested-with field in the Cabal file, but it actually breaks due to a CPP version-gated extension (RankNTypes). Shifting it out fixes the issue, and all tests pass.

(I originally thought GHC 8.2 support was free, but I got confused, so that's not part of this changeset.)

Another approach would be to scrap this PR and simply remove GHC 8.4.4 from the Cabal file.

Also enabled testing on GHC 9.4, because it's supported with no changes.

raehik commented 1 year ago

Looks like GHC 8.2 had a few issues, so this changeset no longer adds it (only tried because it used to be supported and it seemed to need no changes).

acowley commented 1 year ago

Terrific, thank you!