search

Vinyzu / Botright

Botright, the most advance undetected, fingerprint-changing, captcha-solving, open-source automation framework. Build on Playwright, its as easy to use as it is to extend your code. Solving your Captchas for free with AI.
GNU General Public License v3.0
473 stars 60 forks source link

[BUG] socks5 proxy #15

Open wanghaisheng opened 1 year ago

wanghaisheng commented 1 year ago

Describe the bug

  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/tsup-0.1.16-py3.9.egg/tsup/botright/botright.py", line 26, in new_browser
    _proxy = await ProxyManager(self, proxy)
  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/async_class.py", line 173, in __await__
    yield from self.create_task(
  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/tsup-0.1.16-py3.9.egg/tsup/botright/modules/proxy_manager.py", line 28, in __ainit__
    self.split_proxy()
  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/tsup-0.1.16-py3.9.egg/tsup/botright/modules/proxy_manager.py", line 68, in split_proxy
    raise SplitError(f"Proxy Format ({self.proxy}) isnt supported")
tsup.botright.modules.proxy_manager.SplitError: Proxy Format (socks5://127.0.0.1:1080) isnt supported

Code Sample If applicable, add a code sample to replicate the bug.

To Reproduce

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

gryffus commented 1 month ago

Do I understand it correctly, that there is currently no way to get SOCKS5 working with botright?

wanghaisheng commented 1 month ago

i can say last i try is failure, currently i have no idea

gryffus commented 1 month ago

Why did you close it, then? šŸ¤£ @wanghaisheng

gryffus commented 1 month ago

@wanghaisheng can you please reopen the issue? It's not solved yet. Thanks.

wanghaisheng commented 1 month ago

@gryffus why bother that? for a year without any response

gryffus commented 1 month ago

This is not how development works. The author does this in his free time and does not "owe" you any fixes or implementation. Not even communication.

Regardless, the issue is still existing and thus there is no reason to close it yet. "It takes too long" is not a reason for closing an issue.

If you want it implemented sooner, just sponsor the project and I am sure it will get through :).

gryffus commented 1 month ago

Please reopen the issue. Thanks @wanghaisheng

Vinyzu commented 1 month ago

Issue will be worked on (someday).

gryffus commented 1 month ago

Thanks @Vinyzu