search

Vinzent03 / tab-switcher

Tab Switcher - Obsidian Plugin
GNU General Public License v3.0
123 stars 6 forks source link

Reverse Cycling from first to last #9

Closed kemonprogrammer closed 2 years ago

kemonprogrammer commented 2 years ago

Great plugin!

I don't know if it is already implemented (to my knowledge not), but when I am on the first pane and want to reverse cycle (to the last pane), it does not work.

This could be an improvement:

TLDR

Improvement:

phibr0 commented 2 years ago

Fixed in Release 0.0.9

paper-st commented 2 years ago

Sadly, this still doesn't work for me in 0.0.9. Wouldn't it make sense to also make it work the other way around, i.e. going from the last pane to the first pane with CTRL + TAB?

Love the plugin otherwise!

Vinzent03 commented 2 years ago

@paper-st Sorry, but I can't reproduce your issue. For me, it works in both directions, from last to first and from first to last. Could you share a video or description of your pane setup? (How many. Which pane types,..)

paper-st commented 2 years ago

I found my mistake: I had a pinned note on the bottom right corner in preview mode. I assumed that notes in preview mode are simply skipped over (I actually forgot that this is also a pane). When I removed it, it works as intended.

Might be a nice improvement to just have it behave as if these notes weren't there, so one can still cycle through. Anyway, thanks for the help!

Vinzent03 commented 2 years ago

It shouldn't be skipped, because it allows you to cycle to a preview pane and switch it to edit mode. In your case, should another CTRL + TAB press fixed it, because it first goes to the bottom pane and then to the start.

paper-st commented 2 years ago

As you said, it is not about edit/preview mode, but about having a note open in the sidebar. If there is a note there, edit mode or not, I neither can move to it nor over it. The rightmost file of the "main screen" stays active. I get this behaviour even if the sidebar is collapsed.

Vinzent03 commented 2 years ago

Ah you are talking about a note in the sidebar. You didn't mention that. I thought you mean a note in the root in the bottom right corner. You are right, there is a bug. Sadly, we already fixed that, but the issue is back again. #7

Vinzent03 commented 2 years ago

@paper-st Should again be fixed now.

paper-st commented 2 years ago

Great, sorry for the confusion with the sidebar. Thanks!