search

ViolaFlower / Re-Console

The leading, well-researched Console edition modpack with a focus on preserving the past and modernizing it into the future.
https://modrinth.com/modpack/legacy-minecraft
GNU General Public License v3.0
50 stars 5 forks source link

"Disable autosave" and "Exit without saving" not working as intended #35

Closed Cjnator38 closed 3 months ago

Cjnator38 commented 4 months ago

Disabling autosave in Re-Console, exiting without saving, then relaunching the world shows that player modifications are still saved to an extent.

First video shows Re-Console 0.3.3 Second video shows Legacy4J 1.6.3c, latest Architectury and Fabric APIs

https://github.com/Legacy-Union/Re-Console/assets/39870226/b83e0960-62fa-451e-9b5f-7a208b4a78c2

https://github.com/Legacy-Union/Re-Console/assets/39870226/a068137e-2255-4312-a741-abe523c359e5

Here you can see that the player modified chunks remain intact, from an apparent autosave, and the blocks destroyed by the TNT after that autosave remain destroyed. The TNT was removed immediately before this screenshot 2024-05-16_23 04 35

omo50 commented 4 months ago

in all likelihood this is a L4J problem, not a Re-Console kne

Exit Without Saving has many issues (including sending you underground), and I can't do anything about auto save.

omo50 commented 4 months ago

wait

omo50 commented 4 months ago

I'm stupid, one second I didn't fully read the comment

Cjnator38 commented 4 months ago

yeah i was experimenting with it and caught the issue on accident, posted it in media chat, and wily pointed out that it has already been tested to not be an issue with l4j

omo50 commented 4 months ago

I'm.. actually completely unsure of the problem regarding auto save then. I can't do anything about the Exit Without Saving issue (to my knowledge). Will leave this open as a way to track

Wilyicaro commented 4 months ago

in all likelihood this is a L4J problem, not a Re-Console kne

Exit Without Saving has many issues (including sending you underground), and I can't do anything about auto save.

This problem of spawning "underground" I believe has not been resolved, because in fact, it is not something that makes any sense what a person expects to happen if you create a world without autosaving and leave the world without saving (the world in LE would be excluded, but I believe it's not currently in Legacy4J)

omo50 commented 3 months ago

Is this still occuring in 0.5.1? I would like to look into this sometime soon

I'm unsure of what I can exactly do about this, but it may be due to (based on assumptions) Faster Random or C2ME? Very uncertain though

Cjnator38 commented 3 months ago

Still occurs on 0.5.1

Cjnator38 commented 3 months ago

Does NOT occur with both mods disabled

Cjnator38 commented 3 months ago

100% seems to be an issue with C2ME. With Faster Random disabled and C2ME enabled, the issue continues. But with Faster Random enabled and C2ME disabled, the issue is gone.

omo50 commented 3 months ago

100% seems to be an issue with C2ME. With Faster Random disabled and C2ME enabled, the issue continues. But with Faster Random enabled and C2ME disabled, the issue is gone.

going to look into this today :3

omo50 commented 3 months ago

This should be fixed by dc4660d