VioletGiraffe / cppcheck-vs-addin

Visual Studio integration for cppcheck, an open-source static code analyzer for C++
MIT License
413 stars 85 forks source link

Infinite loop when saving file, if cppcheck not found #182

Closed claremacrae closed 6 years ago

claremacrae commented 6 years ago

Preconditions:

Observed behaviour:

I know this was user error, but it would be noce to have more graceful behaviour, like if you click Cancel, it cancels the check, rather than keeping on asking again

VioletGiraffe commented 6 years ago

Fixed. That infinite loop probably wasn't such a good idea, huh.

By the way, you can download cppcheck from Github releases: https://github.com/danmar/cppcheck/releases

claremacrae commented 6 years ago

Wow - that's a really quick bug-fix, and thanks for the pointer to the download page too!

VioletGiraffe commented 6 years ago

It really was a quick fix :) You've put more effort into structuring your error report than I did into fixing it. Wish everyone would be as thorough and detailed when reporting issues.