search

VioletGiraffe / file-commander

Cross-platform Total Commander-like orthodox file manager for Windows, Mac and Linux
Apache License 2.0
375 stars 56 forks source link

disable selection without key-modifiers #242

Closed sclown closed 4 years ago

sclown commented 4 years ago

https://github.com/VioletGiraffe/file-commander/issues/212 With separate selection we shouldn't change selection on mouse button without key-modifiers. (The same in Total Commander and Midnight Commander) With this approach it's hard to reset a selection. That's why I've added select/deselect all.

ghost commented 4 years ago

DeepCode Report (#703016)

DeepCode analyzed this pull request. There are no new issues.

VioletGiraffe commented 4 years ago

Great fix, thanks!

VioletGiraffe commented 4 years ago

Did you test how single-click resets selection? It's erratic. I'm sorry but I can only call this broken, the bug #212 is a lesser evil in comparison.

sclown commented 4 years ago

It's because of the selection on mouse move. I've added one more fix to select on the drag. But it has side effect - selection stays after drag attempt. There is a lot of workarounds, that can be solved with custom selection model.