VioletGiraffe / file-commander

Cross-platform Total Commander-like orthodox file manager for Windows, Mac and Linux
Apache License 2.0
374 stars 55 forks source link

Automatically publish `.msix` packages in `/releases`. #288

Closed RokeJulianLockhart closed 2 years ago

RokeJulianLockhart commented 2 years ago

My rationale is available at https://github.com/felixrieseberg/windows95/issues/221#issue-833287302.

VioletGiraffe commented 2 years ago

That certainly would not provide any benefits over the existing InnoSetup installer. What is the motivation behind this request?

RokeJulianLockhart commented 2 years ago

https://github.com/VioletGiraffe/file-commander/issues/288#issuecomment-1002717712

@VioletGiraffe, although numerous benefits are present, the most important is that file://localhost/%SystemDrive%/Program Files/winget/winget.exe and basic package-managers that are similar to file://localhost/%SystemDrive%/Program Files/winget/winget.exe shall be able to properly manage the package. This is partially true for MSI, but MSIX is an open standard, and correct support of it is superior.

VioletGiraffe commented 2 years ago

I hate MSI for its slow operation and especially for littering: it leaves a copy of the MSI package in the "Installers" directory for as long as the application is installed, which is just wasted space (and if you delete this junk, you will lose the ability to properly uninstall the corresponding application). Does MSIX do anything similar?

RokeJulianLockhart commented 2 years ago

https://github.com/VioletGiraffe/file-commander/issues/288#issuecomment-1002796301

@VioletGiraffe, you are able to test this easily, because within file:///%SystemDrive%/ProgramFiles is all of the information that is being stored by software that has been installed by APPX or MSIX installers.

After gaining access to the directory, compare it before and after installation of some software via one MSIX package. My knowledge of this process is that it should not leave any data.

One anecdotal demonstration of this is how uninstallation and subsequent installation of Minecraft: Bedrock Edition during some years previous to now did not retain the data that had been created by it.

VioletGiraffe commented 2 years ago

Thank you for the answer. I still think InnoSetup is superior to MSIX, I'm not interested in learning MSIX and I don't trust it to do the right thing. But you can convince me otherwise by explaining why exactly you don't like the current setup package and why you suggest MSIX specifically of all the different available choices.