search

VioletGiraffe / file-commander

Cross-platform Total Commander-like orthodox file manager for Windows, Mac and Linux
Apache License 2.0
375 stars 56 forks source link

UI font is set to Segoe UI 10, but it should be 9 #297

Open ftphikari opened 1 year ago

ftphikari commented 1 year ago

Standard system font in Windows seems to be Segoe UI 9, 10 looks too squished, so please make it default to 9. Also there is no option to change it anywhere, adding a settings section that allows changing UI font would be useful.

VioletGiraffe commented 1 year ago

The default font for the file list is Roboto Mono Light 9. As for all the other text elements, I don't think I'm altering the default font. Please share a screenshot of the main window so that I could see what the problem looks like.

ftphikari commented 1 year ago

This is when I set font to Segoe UI 9, it now matches the font in the window frame, but font in the rest of the UI is different and looks too squished. image

Segoe UI is the default font for Windows GUI programs by the way, so this program should default to it as well. Most people do not have Roboto fonts.

VioletGiraffe commented 1 year ago

I'm deploying the font with the program, of course no one has it, but it's loaded from the resources. So the question is why it didn't load. The font in the file list should be monospace, which Segoe UI is not. However, I do not touch the font settings for the path navigator combobox which you also highlighted - I don't see anything wrong there.

ftphikari commented 1 year ago

What's wrong there is that it doesn't use the font of the system, or it uses the wrong size, I can't tell. Default font in Windows is Segoe UI 9, every GUI element should use that. Also I should probably be able to change it in the settings.

VioletGiraffe commented 1 year ago

I understand what you mean (for the most part). Looking at the code - yes, I'm increasing the default font size by 1, so if your default was 9, it becomes 10. I do it for the whole application, but I don't change anything else. The default 9 is just too tiny. And I don't see anything squished, not even on your screenshots. It's just ~10% larger in size.

On top of that, the default font specifically for the file list is Roboto Mono Light 9, but you can select any font you like in the preferences.

This +1 to font size could also be made an optional configurable parameter.

ftphikari commented 1 year ago

I highlighter squished part on the screenshot. ik is way closer on the size 10 than on size 9. Either way, it being too tiny is a user preference, since default system uses size 9. Making it 1 point bigger is not desirable because it deviates from the system style. If the user finds system text too small, he can use Windows scaling for it. I recommend going with system default, and adding an option to change the UI font separately.

VioletGiraffe commented 1 year ago

It is only this program where I find the font size too small. But I agree, it should be optional. I'm not a fan of messing with the system default look myself, I wouldn't have done it if it didn't improve my user experience significantly.

VioletGiraffe commented 1 year ago

Did you build File Commander with Qt 6? I'm trying Qt 6.2.2 now, and I see that the whole UI has a non-default font applied, I'm not even sure which one and that's not intended. No such problem with Qt 5.15.2.

ftphikari commented 1 year ago

I didn't build it, I just downloaded latest relase

VioletGiraffe commented 1 year ago

Then it's built with Qt 5, odd.