VirgilSecurity / react-native-virgil-crypto

BSD 3-Clause "New" or "Revised" License
48 stars 17 forks source link

Pod Update Needed to Fix ‘Invalid Executable: The Executable VSCCommon Contains Bitcode’ Error #85

Open anasmassnaoui opened 1 month ago

anasmassnaoui commented 1 month ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

I encountered an issue where the app submission to TestFlight was rejected due to the error: “Invalid Executable: The executable ‘VSCCommon’ contains bitcode.” This problem arose after updating the VSCCommon framework in my project.

Today I used patch-package to patch react-native-virgil-crypto@0.6.4 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-virgil-crypto/RNVirgilCrypto.podspec b/node_modules/react-native-virgil-crypto/RNVirgilCrypto.podspec
index b3464d6..4288cb9 100644
--- a/node_modules/react-native-virgil-crypto/RNVirgilCrypto.podspec
+++ b/node_modules/react-native-virgil-crypto/RNVirgilCrypto.podspec
@@ -16,7 +16,7 @@ Pod::Spec.new do |s|
   s.static_framework = true

   s.dependency 'React'
-  s.dependency 'VirgilCrypto', '5.3.0'
-  s.dependency 'VirgilCryptoFoundation', '0.12.0'
-  s.dependency 'VirgilCryptoPythia', '0.12.0'
+  s.dependency 'VirgilCrypto', '7.0.1'
+  s.dependency 'VirgilCryptoFoundation', '0.17.1'
+  s.dependency 'VirgilCryptoPythia', '0.17.1'
 end
diff --git a/node_modules/react-native-virgil-crypto/ios/Podfile b/node_modules/react-native-virgil-crypto/ios/Podfile
index ee78d50..59ee910 100644
--- a/node_modules/react-native-virgil-crypto/ios/Podfile
+++ b/node_modules/react-native-virgil-crypto/ios/Podfile
@@ -34,7 +34,7 @@ target 'RNVirgilCrypto' do
   pod 'Folly', podspec: '../node_modules/react-native/third-party-podspecs/Folly.podspec'

   # Dependencies
-  pod 'VirgilCrypto', '5.3.0'
-  pod 'VirgilCryptoFoundation', '0.12.0'
-  pod 'VirgilCryptoPythia', '0.12.0'
+  pod 'VirgilCrypto', '7.0.1'
+  pod 'VirgilCryptoFoundation', '0.17.1'
+  pod 'VirgilCryptoPythia', '0.17.1'
 end

This issue body was partially generated by patch-package.

SergeySeroshtan commented 1 month ago

Hi @anasmassnaoui. Thank you for your interest on the project. I will try to apply the patch.