search

VirgilSecurity / virgil-sdk-x

Virgil Core SDK allows developers to get up and running with Virgil Cards Service API quickly and add end-to-end security to their new or existing digital solutions to become HIPAA and GDPR compliant and more.
https://virgilsecurity.com/
Other
27 stars 5 forks source link

V5 develop #11

Closed Ogerets closed 6 years ago

SanjoDeundiak commented 6 years ago

@Ogerets

  1. Why would we need test_data.txt, if we have data.json?
  2. What's the difference between ImportedKeyEntry and KeyEntry?
Ogerets commented 6 years ago

@SanjoDeundiak

  1. We don't need it indeed.
  2. ImportedKeyEntry contains imported PrivateKey, not Data, and don't have name, but still has meta. It provides the return type of PrivateKeyStorage's load function. The idea of PrivateKeyStorage wrapper, I thought, was to exclude work with PrivateKeyExporter for facilitate reason.
SanjoDeundiak commented 6 years ago

@Ogerets PrivateKeyEntry would sound much better instead, as ImprotedKeyEntry doesn't really show what the intend is

SanjoDeundiak commented 6 years ago

@Ogerets renaming file does not rename class...