Closed minenordlicht closed 1 year ago
Why not make a custom cardVerifier that suits your needs? @minenordlicht
Why not make a custom cardVerifier that suits your needs? @minenordlicht @Scratch-net It is not possible. I can make copy of this class and rewrite this line, but It is not possible to pass it into card verifier. Also it is not possible to create custom EThree object because many constructors inside init method are private or internal, so they are not accessible outside of library (e.g. LocalKeyStorage, CloudKeyManager, SQLiteCardStorage, LookupManager, CloudRatchetStorage....)
Accepting this PR won't solve your problems, right? You would still need a new library version on cocoaPods?
Accepting this PR won't solve your problems, right? You would still need a new library version on cocoaPods?
It will solve issue. Ideally, it will be nice to have normal release lets say version v8.2.1. Then also virgil-e3kit-x needs to have update dependency to this version.
Ok, let's start with merging this PR and see what we can do else a bit later
Ok, let's start with merging this PR and see what we can do else a bit later
Thanks. If you create new release of this library v8.2.1, I can prepare PR with updated dependencies for CocoaPods and SPM in libraries which used this as dependency. It is libraries:
Hey @minenordlicht I think this and other dependent packages were updated. Could you please check?
Change static properties to var make solution more dynamic for On-premise hosted Virgil backend services